should not use a seperate command to launch debug
Created by: myrfy001
The current plugin will be activated by pressing a Cmd+Shift+p, and select a command to launch the debugger. And after running that command, the extension is activated and then send another workbench.action.debug.start
command, which leading to the real debugger adapter to be launched. This interactivate flow has some drawbacks:
-
workbench.action.debug.start
will launch the debug session with the current selected configuration, if the user created multiple configs inlaunch.json
and selected some one else, then the extension will fail to continue. - starting the debug session by sending
workbench.action.debug.start
introduce some indirection on the interactivate flow, the plugin hide some part of the background work from the user (e.g. send theworkbench.action.debug.start
command), but left some other parts that the user can interactivate with (e.g., modify thelaunch.json
). So, the user will confused on what is the difference between clicking the green debug button and runcore-debugger.launchCoreDebugger
from the command panel.
IMO, the debug plugin should be activated only by click the green debug button, or by pressing the F5.