consolewrite does not need cons.lock -- can lead to sleep() with lock held

13dccb03 · Robert Morris · Frans Kaashoek · d4cecb26 · 13dccb03
Commit 13dccb03 authored 4 years ago by Robert Morris Committed by Frans Kaashoek 4 years ago
Hide whitespace changes
Inline Side-by-side

Showing

with 0 additions and 2 deletions
+0 -2
--- a/kernel/console.c
+++ b/kernel/console.c
@@ -60,14 +60,12 @@ consolewrite(int user_src, uint64 src, int n)
 {
  int i;

-  acquire(&cons.lock);
  for(i = 0; i < n; i++){
    char c;
    if(either_copyin(&c, user_src, src+i, 1) == -1)
      break;
    uartputc(c);
  }
-  release(&cons.lock);

  return i;
 }